Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jans-pycloudlib): detect JSON data format #10009

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat(jans-pycloudlib): detect JSON data format #10009

merged 4 commits into from
Nov 1, 2024
+80 −1

Conversation

iromli
Copy link
Contributor

@iromli iromli commented Nov 1, 2024

Prepare

Description

Target issue

closes #10008

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

@iromli iromli self-assigned this Nov 1, 2024
@dryrunsecurity DryRunSecurity
Copy link

dryrunsecurity bot commented Nov 1, 2024 •
edited
Loading

DryRun Security Summary

We are currently analyzing this pull request to produce a meaningful summary.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-pycloudlib kind-feature Issue or PR is a new feature request labels Nov 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-pycloudlib'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@iromli iromli marked this pull request as ready for review November 1, 2024 18:48
@iromli iromli requested a review from moabu as a code owner November 1, 2024 18:48
@moabu moabu merged commit 4f155cf into main Nov 1, 2024
31 of 32 checks passed
@moabu moabu deleted the cn-pycloudlib-json-check branch November 1, 2024 19:18
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 19.14894% with 38 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@701bd17). Learn more about missing BASE report.

Files with missing lines Patch % Lines
jans-pycloudlib/jans/pycloudlib/persistence/sql.py 19.14% 38 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10009   +/-   ##
=======================================
  Coverage        ?   58.33%           
=======================================
  Files           ?       40           
  Lines           ?     3571           
  Branches        ?        0           
=======================================
  Hits            ?     2083           
  Misses          ?     1488           
  Partials        ?        0
Flag Coverage Δ
unittests 58.33% <19.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-cli'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-linux-setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed for 'jans-core'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moabu moabu moabu approved these changes

Assignees

@iromli iromli

Labels
comp-jans-pycloudlib kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(jans-pycloudlib): detect JSON data format
3 participants
@iromli @moabu @mo-auto